[TD] Update api/base64 to use jsg::BufferSource#4908
Merged
Conversation
Avoid an additional copy when returning results to JS by using a jsg::BufferSource as the output type. Since we are running in the v8 sandbox now, kj::Array<kj::byte> allocations that are not backed by a v8::BackingStore are more expensive because they require a copy to get the data into the sandbox.
b747d6b to
47f34f2
Compare
npaun
reviewed
Aug 27, 2025
npaun
reviewed
Aug 27, 2025
jasnell
commented
Aug 27, 2025
jasnell
commented
Aug 27, 2025
jasnell
commented
Aug 27, 2025
Co-authored-by: Nicholas Paun <npaun@cloudflare.com>
npaun
reviewed
Aug 27, 2025
npaun
approved these changes
Aug 27, 2025
jasnell
commented
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid an additional copy when returning results to JS by using a jsg::BufferSource as the output type. Since we are running in the v8 sandbox now, kj::Arraykj::byte allocations that are not backed by a v8::BackingStore are more expensive because they require a copy to get the data into the sandbox.
(
TD== Technical Debt)