Skip to content

[build] Update bzlmod dependencies#4892

Merged
fhanau merged 1 commit intomainfrom
felix/082525-bazel-840
Sep 5, 2025
Merged

[build] Update bzlmod dependencies#4892
fhanau merged 1 commit intomainfrom
felix/082525-bazel-840

Conversation

@fhanau
Copy link
Copy Markdown
Contributor

@fhanau fhanau commented Aug 25, 2025 •
edited
Loading

@fhanau fhanau requested review from a team as code owners August 25, 2025 19:58
fhanau
fhanau commented Aug 25, 2025
View reviewed changes
@npaun
Copy link
Copy Markdown
Member

npaun commented Aug 25, 2025

Something seems very fried on macOS:

This code requires C++20. Either your compiler does not support it or it is not enabled.

@fhanau
Copy link
Copy Markdown
Contributor Author

fhanau commented Aug 25, 2025

Something seems very fried on macOS:

This code requires C++20. Either your compiler does not support it or it is not enabled.

Yeesh, looks like our -std=c++20 flag is being overwritten with -std=c++17. Will have to look at what's causing it (likely apple_support being updated)

@fhanau fhanau force-pushed the felix/082525-bazel-840 branch from 55d4b85 to 79bfbef Compare August 28, 2025 16:37
@fhanau fhanau force-pushed the felix/082525-bazel-840 branch from 79bfbef to 73173d6 Compare September 4, 2025 19:31
@fhanau
Copy link
Copy Markdown
Contributor Author

fhanau commented Sep 4, 2025

Something seems very fried on macOS:
This code requires C++20. Either your compiler does not support it or it is not enabled.

Yeesh, looks like our -std=c++20 flag is being overwritten with -std=c++17. Will have to look at what's causing it (likely apple_support being updated)

This was fixed with an apple_support patch release.

@fhanau fhanau requested a review from mikea September 4, 2025 19:39
@npaun
Copy link
Copy Markdown
Member

npaun commented Sep 4, 2025

Damn CI is taking 4ever on this one. I came back after two hours and it's still not done. Anyway it clearly does build on on our supported platforms so LGTM.

@fhanau fhanau force-pushed the felix/082525-bazel-840 branch from 73173d6 to 7a8bbdf Compare September 5, 2025 13:40
@fhanau fhanau force-pushed the felix/082525-bazel-840 branch from 7a8bbdf to 6e9bc63 Compare September 5, 2025 16:28
@fhanau fhanau changed the title [build] Roll Bazel -> 8.4.0, update bzlmod dependencies [build] Update bzlmod dependencies Sep 5, 2025
@fhanau
Copy link
Copy Markdown
Contributor Author

fhanau commented Sep 5, 2025

The Bazel 8.4.0 update causes two python tests to consistently fail 🙄
Updated the PR to only bump bzlmod dependencies

@fhanau fhanau merged commit 8800bf1 into main Sep 5, 2025
21 checks passed
@fhanau fhanau deleted the felix/082525-bazel-840 branch September 5, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@npaun npaun npaun approved these changes

@mikea mikea Awaiting requested review from mikea

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fhanau @npaun