Conversation
anonrig
reviewed
Aug 25, 2025
f22f763 to
937f71c
Compare
Scratching a long-time itch. Not to be confused with jsg::Function, which is a type-safe wrapper around a JS function that passes arguments and return values through the JSG type wrapper layer, the JsFunction is a thin wrapper around a v8::Function that aligns with jsg::JsValue and friends. This can be used to replace direct uses of v8::Function to simplify calling functions and handling the check(...) for error handling.
937f71c to
d8019c9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
npaun
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scratching a long-time itch. Not to be confused with jsg::Function, which is a type-safe wrapper around a JS function that passes arguments and return values through the JSG type wrapper layer, the JsFunction is a thin wrapper around a v8::Function that aligns with jsg::JsValue and friends. This can be used to replace direct uses of v8::Function to simplify calling functions and handling the check(...) for error handling.
(TD == Technical Debt... this probably doesn't strictly qualify but it's something that's been on my backlog for many many months... there are a number of places throughout the code that can be updated to use this to simplify function call sites)