EW-9366 [o11y] Implement proper timestamp support for STW#4767
Merged
Conversation
fhanau
commented
Aug 13, 2025
a3e812e to
7814976
Compare
Contributor
Author
|
Ready for review. Downstream PR |
danlapid
reviewed
Aug 26, 2025
danlapid
reviewed
Aug 26, 2025
danlapid
approved these changes
Aug 26, 2025
This is needed as the completion time stamp may not yet be available at this time. Also remove irrelevant "worker" spans from kv-instrumentation-test (which were highly unstable and would need to be updated here otherwise). - Create IncomingRequest::now to avoid calling clockRead() twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4689 needs to land first.Changes are done, but the hack described in a comment merits discussionand there is one remaining TODO.