Skip to content

EW-9365 [o11y] Implement proper Streaming Tail Worker API#4727

Merged
fhanau merged 1 commit intomainfrom
felix/061725-user-tracing-separate-next-p1
Sep 5, 2025
Merged

EW-9365 [o11y] Implement proper Streaming Tail Worker API#4727
fhanau merged 1 commit intomainfrom
felix/061725-user-tracing-separate-next-p1

Conversation

@fhanau
Copy link
Copy Markdown
Contributor

@fhanau fhanau commented Aug 8, 2025

This implements the Streaming Tail Worker API as discussed previously, should be a lot more elegant and less error-prone.
What isn't cleaned up yet:

  • Commit history, splitting this into more digestible commits (possible to some extent)
  • Many TODOs are cleared up, one is added about the Onset spanId.
  • We have good tests for the spanId field defined for SpanOpen, its meaning has changed and it's now actually called spanId. We'd still want more coverage for the outer spanId defined in TailEvent, which is not included in tests as we only look at the inner event so that tests are deterministic (TailEvent includes timestamp) @mar-cf if you want to develop tests that should be helpful still, or I can add them here

Downstream PR to follow.

@fhanau fhanau requested a review from mar-cf August 8, 2025 01:30
@fhanau fhanau requested review from a team as code owners August 8, 2025 01:30
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 8, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@fhanau fhanau force-pushed the felix/061725-user-tracing-separate-next-p1 branch from 962f460 to d85c222 Compare August 8, 2025 01:43
Copy link
Copy Markdown
Collaborator

@danlapid danlapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed from my phone so might have missed some things
Will take another look tomorrow.

@fhanau fhanau force-pushed the felix/061725-user-tracing-separate-next-p1 branch 2 times, most recently from 2b78ed3 to c265626 Compare August 20, 2025 18:14
@fhanau fhanau force-pushed the felix/061725-user-tracing-separate-next-p1 branch 10 times, most recently from 6bb8c06 to b6da450 Compare September 3, 2025 21:12
@fhanau fhanau force-pushed the felix/061725-user-tracing-separate-next-p1 branch from b6da450 to ad00f18 Compare September 4, 2025 00:49
@fhanau fhanau force-pushed the felix/061725-user-tracing-separate-next-p1 branch from ad00f18 to ae6daf4 Compare September 4, 2025 21:07
@fhanau fhanau merged commit 5165e8b into main Sep 5, 2025
21 of 22 checks passed
@fhanau fhanau deleted the felix/061725-user-tracing-separate-next-p1 branch September 5, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants