Resolve several multiple-bool-args lints#4639
Merged
Conversation
harrishancock
commented
Jul 30, 2025
harrishancock
commented
Jul 30, 2025
harrishancock
commented
Jul 30, 2025
ba88f3c to
84fade2
Compare
jasnell
approved these changes
Jul 30, 2025
84fade2 to
1ce3f58
Compare
This resolves a new downstream lint.
This resolves a new downstream lint. This also makes it a strong bool for good measure.
This resolves a new downstream lint. This is not marked [nfc] because there are two bugfixes in this commit: - The reportProgress flag is now being respected. Previously we were alwyas reporting progress. - The exposeInternals flag is now being properly interpreted. Previously we were passing it, un-negated, to a parameter named hide_internals. I switched to the options struct version of the V8 TakeHeapSnapshot() function for greater clarity.
1ce3f58 to
1929408
Compare
joshthoward
pushed a commit
that referenced
this pull request
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Soon, I intend to land a new clang-tidy plugin downstream which squawks if we have functions which accept more than one boolean parameter.
We run our clang-tidy with warnings-as-errors for as much of our codebase as we can, including some workerd directories. This PR resolves the lints which cropped up in workerd when I ran it.
In doing so, I discovered a couple minor bugs in our heap snapshot functionality.