Skip to content

Implement node:fs ReadStream#4475

Merged
jasnell merged 2 commits intomainfrom
jasnell/node-fs-streams
Jul 8, 2025
Merged

Implement node:fs ReadStream#4475
jasnell merged 2 commits intomainfrom
jasnell/node-fs-streams

Conversation

@jasnell
Copy link
Collaborator

@jasnell jasnell commented Jul 7, 2025

Implements fs.createReadStream(...) and fs.ReadStream

@jasnell jasnell force-pushed the jasnell/node-fs-streams branch 2 times, most recently from 3eb3522 to 4927dab Compare July 7, 2025 21:06
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@jasnell jasnell force-pushed the jasnell/node-fs-streams branch 4 times, most recently from c3b97ea to 7b22492 Compare July 8, 2025 17:04
@jasnell jasnell changed the title Implement node:fs ReadStream and WriteStream Implement node:fs ReadStream Jul 8, 2025
@jasnell jasnell force-pushed the jasnell/node-fs-streams branch from 7b22492 to d8941e0 Compare July 8, 2025 18:32
@jasnell jasnell marked this pull request as ready for review July 8, 2025 18:33
@jasnell jasnell requested review from a team as code owners July 8, 2025 18:33
@jasnell jasnell requested review from a team July 8, 2025 18:33
Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a comprehensive review, but looks good to me.

@jasnell jasnell merged commit c56608d into main Jul 8, 2025
20 checks passed
@jasnell jasnell deleted the jasnell/node-fs-streams branch July 8, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants