Skip to content

suppress unnecessary microsoft-unqualified-friend warning#4377

Merged
anonrig merged 1 commit intomainfrom
yagiz/suppress-windows-warning
Jun 19, 2025
Merged

suppress unnecessary microsoft-unqualified-friend warning#4377
anonrig merged 1 commit intomainfrom
yagiz/suppress-windows-warning

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Jun 19, 2025

This suppresses the following warning on Windows

bazel-out/x64_windows-opt/bin/src/workerd/io/_virtual_includes/io\workerd/api\blob.h(115,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]
  115 |   friend class File;
      |                ^
      |                ::workerd::
1 warning generated.

@anonrig anonrig requested review from a team as code owners June 19, 2025 16:08
@anonrig anonrig enabled auto-merge (rebase) June 19, 2025 16:17
@anonrig anonrig merged commit 7218b3b into main Jun 19, 2025
20 checks passed
@anonrig anonrig deleted the yagiz/suppress-windows-warning branch June 19, 2025 18:03
@kentonv
Copy link
Member

kentonv commented Jun 20, 2025

Wouldn't it have been easier to fix the warning by adding the qualifier?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants