Skip to content

Revert "update internal state on container.destroy"#4370

Merged
kentonv merged 1 commit intomainfrom
revert-4365-yagiz/set-running-false
Jun 18, 2025
Merged

Revert "update internal state on container.destroy"#4370
kentonv merged 1 commit intomainfrom
revert-4365-yagiz/set-running-false

Conversation

@kentonv
Copy link
Member

@kentonv kentonv commented Jun 18, 2025

Reverts #4365

This is not the correct solution, per internal conversation.

@kentonv kentonv requested a review from anonrig June 18, 2025 16:40
@kentonv kentonv requested review from a team as code owners June 18, 2025 16:40
@anonrig
Copy link
Member

anonrig commented Jun 18, 2025

Opened a PR to address this: #4371

@kentonv kentonv enabled auto-merge June 18, 2025 16:59
@kentonv kentonv disabled auto-merge June 18, 2025 17:26
@kentonv kentonv merged commit cc38385 into main Jun 18, 2025
19 of 20 checks passed
@kentonv kentonv deleted the revert-4365-yagiz/set-running-false branch June 18, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants