Don't report disk usage in Windows build.#4364
Merged
Conversation
For some reason this step takes 16 minutes on Windows. It only takes a couple seconds on Mac and Linux. I assume these usage stats are not actually that important to collect on every build, so let's disable it.
fhanau
approved these changes
Jun 18, 2025
Contributor
fhanau
left a comment
There was a problem hiding this comment.
I've seen it take longer on Windows, but generally at most 60s – might not me a major issue in the average case but I'm open to disabling it here.
Member
Author
|
I just checked the last five successful builds and saw: 1m6s, 10m52s, 16m13s, 1m5s, 52s So yes, I guess it often takes only a minute, but also often takes 10+ minutes. |
penalosa
approved these changes
Jun 18, 2025
Member
Author
|
Internal build failure obviously spurious, bypassing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason this step takes 16 minutes on Windows. It only takes a couple seconds on Mac and Linux.
I assume these usage stats are not actually that important to collect on every build, so let's disable it.