NodeJS Compat: improved process compatibility under a compat flag#4355
Merged
guybedford merged 4 commits intomainfrom Jun 18, 2025
Merged
NodeJS Compat: improved process compatibility under a compat flag#4355guybedford merged 4 commits intomainfrom
guybedford merged 4 commits intomainfrom
Conversation
e2f8f28 to
ce9b56b
Compare
vicb
reviewed
Jun 17, 2025
vicb
reviewed
Jun 17, 2025
anonrig
reviewed
Jun 17, 2025
c3492f6 to
f91c587
Compare
anonrig
approved these changes
Jun 18, 2025
dc61a10 to
5262cd4
Compare
5262cd4 to
f26da4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reinstates #4271 exactly as in that PR, but with the exception that all new process properties, methods are exported as
undefinedunless the new experimentalnodejs_compat_processflag is set. In addition theprocessglobal will not extend from event emitter unless this flag is set.This way all user-facing changes on this PR can be gated behind a compat date.
The goal for removing experimental here would be to complete the stdio implementations ideally as well since these are often expected to find on process, but I would like to add those as a secondary follow-on PR still. Then we can look at removing experimental and enabling the compat date at some point next month ideally.