Conversation
it doesn't seem to be needed anymore
fhanau
approved these changes
Jun 6, 2025
Contributor
fhanau
left a comment
There was a problem hiding this comment.
You're right that this isn't needed anymore in workerd at present, since we use an official abseil release in bzlmod. If we were to go back to what we did before (build with a git commit from chromium absl) we'd need it again – approving but if we merge this we might have to add it back at a later time if V8 ends up needing more recent absl changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it doesn't seem to be needed anymore