Skip to content

[o11y] Fold up unused and redundant tracing code#4260

Merged
fhanau merged 3 commits intomainfrom
felix/060425-STW-tidy
Jun 5, 2025
Merged

[o11y] Fold up unused and redundant tracing code#4260
fhanau merged 3 commits intomainfrom
felix/060425-STW-tidy

Conversation

@fhanau
Copy link
Contributor

@fhanau fhanau commented Jun 5, 2025

No description provided.

@fhanau fhanau requested review from jasnell and mar-cf June 5, 2025 03:40
@fhanau fhanau requested review from a team as code owners June 5, 2025 03:40
Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

fhanau added 3 commits June 5, 2025 10:43
- Reduce timeouts in tail-worker-test, this is heavily used in testing STW
  changes.
- Use ConstString in attribute to reduce memory allocations, as with existing
  span tags
- Deduplicate capnp span tag/attribute definitions
- Deduplicate attribute operations
- Fold up some kj::Vector instances using KJ_MAP
@fhanau fhanau force-pushed the felix/060425-STW-tidy branch from 5ada1d0 to 47e155e Compare June 5, 2025 14:43
@fhanau fhanau requested a review from danlapid June 5, 2025 14:47
@fhanau fhanau merged commit 5c342b8 into main Jun 5, 2025
28 of 29 checks passed
@fhanau fhanau deleted the felix/060425-STW-tidy branch June 5, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants