Conversation
jasnell
approved these changes
Jun 4, 2025
anonrig
reviewed
Jun 4, 2025
| for (const subtest of this.subtests) { | ||
| const err = subtest.error; | ||
|
|
||
| if (err instanceof Error) { |
Member
There was a problem hiding this comment.
We have Error.isError() now :-))
Member
Author
There was a problem hiding this comment.
Will take care of it in the next PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the initial PR to enable WPT reporting, so we can add our results to wpt.fyi.
Here's what we have so far:
GEN_TEST_REPORT=1is set when running a WPT test, we get awpt reportcompatible JSON result.GEN_TEST_STATS=1is set when running a WPT test, we get a Markdown table row that summarizes the results.GEN_TEST_CONFIG=1that creates a blank template for test configuration, listing each test in a WPT module.What's missing - I plan to add these in further PRs later
// METAcomment at the top of a file should appear as a separate test. The test URL then gets?variant=whatevaqdded as a query paramisExpectedFailurecorrectly in the report. I hardcoded it totrue, which is correct in main but might not be in local dev.GEN_TEST_REPORT: Fill out some metadata about workerd version/commit and add all results. Upload to wpt.fyiGEN_TEST_STATS: Append all of these table rows into one table and put it in the action output somewhere so we can get a human readable summary