Skip to content

Separate disabled and omitted tests in WPT reports and coverage#4252

Merged
npaun merged 1 commit intomainfrom
npaun/reclassify-wpt
Jun 4, 2025
Merged

Separate disabled and omitted tests in WPT reports and coverage#4252
npaun merged 1 commit intomainfrom
npaun/reclassify-wpt

Conversation

@npaun
Copy link
Member

@npaun npaun commented Jun 4, 2025

This PR splits skipped tests into two categories:

  • disabl,edTests: We eventually want to pass these, but right now we can't because either:
    • They crash workerd
    • The harness can't handle them
    • They test a feature we haven't implemented but might implement in the future.
  • omittedTests: Do not include in our WPT report or coverage stats, because:
    • They're not reflective of an actual standard (e.g. most tentative tests)
    • They're not relevant server-side
    • We don't intend to support this feature
    • The file isn't a test but is picked up by our globs in bazel anyway
    • etc.

Please let me know if I've misclassified any of our existing tests.

@npaun npaun requested review from anonrig and jasnell June 4, 2025 17:25
@npaun npaun requested review from a team as code owners June 4, 2025 17:25
Copy link
Contributor

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 To request another review, post a new comment with "/windsurf-review".

@npaun npaun force-pushed the npaun/reclassify-wpt branch from fe1bd9b to 5a9f726 Compare June 4, 2025 18:28
@npaun npaun changed the title Separate skipped and excluded tests from WPT reports and coverage Separate disabled and omitted tests in WPT reports and coverage Jun 4, 2025
@npaun npaun requested a review from anonrig June 4, 2025 18:29
@npaun npaun merged commit dab3e32 into main Jun 4, 2025
18 of 22 checks passed
@npaun npaun deleted the npaun/reclassify-wpt branch June 4, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants