Merged
Conversation
anonrig
approved these changes
Jun 3, 2025
- Clean up duplicate bazelrc directive - Clean up remnants of old protobuf identifier - Update ancillary bzlmod dependencies - Ensure that apple_support is pulled in before rules_cc under bzlmod - Drop duplicate --disk_cache bazel args in CI – this is already covered by build/ci.bazelrc.
5e5b5b5 to
84e8985
Compare
This resulted in tests being run three times due to the new sh_test targets (or at least appearing as three test targets due to using cc_test). Use cc_binary instead, manually add linkstatic attribute so that this will still be linked dynamically on Linux as before.
84e8985 to
8c4c099
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.