Merged
Conversation
Contributor
|
I ran into an unexpected issue while reviewing this PR. Please try again later. |
df872f5 to
f7aa8df
Compare
Collaborator
|
Super helpful you are windsurf-bot |
10051a4 to
20764d0
Compare
npaun
reviewed
May 30, 2025
jasnell
approved these changes
May 30, 2025
npaun
reviewed
May 30, 2025
npaun
approved these changes
May 30, 2025
020af9d to
42098c8
Compare
|
The generated output of |
fhanau
reviewed
Jun 4, 2025
017d83c to
87ac3d1
Compare
danlapid
reviewed
Jun 19, 2025
87ac3d1 to
0860e16
Compare
danlapid
reviewed
Jun 19, 2025
GetContinuationPreservedEmbedderData and SetContinuationPreservedEmbedderData Were replaced by v8 versions that generalized the solution for any v8::Data type. Since we are only placing v8::Value the conversion `.As<v8::Value>` is safe.
danlapid
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request includes a new patch to update the BUILD.bazel of v8 to include changes necessary to add dragonbox dependency.