Conversation
npaun
approved these changes
May 22, 2025
jasnell
previously approved these changes
May 22, 2025
Collaborator
jasnell
left a comment
There was a problem hiding this comment.
I'd prefer to hold off on merging this until we're a bit more settled on the questions around how we are going to implement node:http as a whole (the whole on fetch vs. on node.net question).
Member
Author
@jasnell I wonder how are these changes are related to that decision. Can you elaborate? |
395c82d to
e362c14
Compare
e362c14 to
51efe58
Compare
jasnell
reviewed
May 24, 2025
jasnell
approved these changes
May 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds constants and couple of other methods that can be land before the internal discussion for node:http and node:https is completed. These functionalities are in par with Node.js