Refactor: Give Worker::Script::ScriptSource same treatment as ModulesSource.#4126
Merged
Refactor: Give Worker::Script::ScriptSource same treatment as ModulesSource.#4126
Conversation
jasnell
approved these changes
May 22, 2025
…Source. This is a continuation of #4082. I had left `ScriptSource` still containing a weird callback because I didn't think I needed to update it. Turns out I do actually need to update it to avoid some ugliness later. Luckily this turned out to be a much smaller refactor. I would have done it in the first place had I realized.
b17e86a to
8123c13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #4082. I had left
ScriptSourcestill containing a weird callback because I didn't think I needed to update it. Turns out I do actually need to update it to avoid some ugliness later.Luckily this turned out to be a much smaller refactor. I would have done it in the first place had I realized.