Initial impl of the internal worker-fs API#4097
Merged
Conversation
jasnell
commented
May 6, 2025
74ec2ba to
82dde63
Compare
anonrig
approved these changes
May 6, 2025
danlapid
reviewed
May 7, 2025
danlapid
reviewed
May 7, 2025
danlapid
reviewed
May 7, 2025
danlapid
reviewed
May 7, 2025
danlapid
reviewed
May 7, 2025
danlapid
reviewed
May 7, 2025
danlapid
approved these changes
May 7, 2025
This is split off from a larger PR to hopefully make it easier to review. Unfortunately, splitting it off does mean that that there's not a lot of context available for how this is intended to be used. It is expected that this internal part may need to evolve further as the rest of the implementation is fleshed out. While an internal PR will be necessary in order for this to land, it is not expected that this initial PR will be accessible/usable by users until the rest of the implementation is complete.
82dde63 to
ce82d10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First batch of changes separated out from #4029
This is split off from a larger PR to hopefully make it easier to review. Unfortunately, splitting it off does mean that that there's not a lot of context available for how this is intended to be used. It is expected that this internal part may need to evolve further as the rest of the implementation is fleshed out. While an internal PR will be necessary in order for this to land, it is not expected that this initial PR will be accessible/usable by users until the rest of the implementation is complete. Please refer to the larger PR for context on how these new APIs would be intended to be used.