[o11y] Update Streaming Tail Worker Attributes definition#4095
Merged
Conversation
fhanau
commented
May 6, 2025
|
The generated output of |
b259e37 to
812f522
Compare
ce261a2 to
3e5de1a
Compare
Contributor
Author
|
This requires a review from @cloudflare/wrangler team based on the type changes. |
jasnell
approved these changes
May 6, 2025
penalosa
approved these changes
May 7, 2025
812f522 to
36def05
Compare
3e5de1a to
d0fb590
Compare
This should be easier to process in the tail worker. Note that only the JS side is updated and we still use a plain array internally, this makes this change simpler and avoids needing e.g. capnp definition changes. Alongside this change, update the name of the handler for these events to "attributes", which is more descriptive.
d0fb590 to
91f6875
Compare
danlapid
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be easier to process in the tail worker. Note that only the JS side is updated and we still use a plain array internally, this makes this change simpler and avoids needing e.g. capnp definition changes.
Alongside this change, update the name of the handler for these events to "attributes", which is more descriptive.