Merged
Conversation
70063bd to
62b8370
Compare
hoodmane
reviewed
Apr 25, 2025
hoodmane
reviewed
Apr 25, 2025
hoodmane
reviewed
Apr 25, 2025
54bf0c6 to
4451eac
Compare
hoodmane
reviewed
Apr 25, 2025
949b5c8 to
bb0767f
Compare
61fffba to
d2bc3c2
Compare
Collaborator
|
I'll review tomorrow |
d2bc3c2 to
619985c
Compare
Contributor
Author
|
@danlapid sure |
danlapid
reviewed
Apr 28, 2025
danlapid
reviewed
Apr 28, 2025
danlapid
reviewed
Apr 28, 2025
7785efa to
a46583a
Compare
hoodmane
reviewed
May 1, 2025
hoodmane
reviewed
May 1, 2025
hoodmane
reviewed
May 1, 2025
hoodmane
reviewed
May 1, 2025
hoodmane
reviewed
May 1, 2025
hoodmane
reviewed
May 1, 2025
hoodmane
reviewed
May 1, 2025
hoodmane
reviewed
May 1, 2025
hoodmane
reviewed
May 1, 2025
hoodmane
reviewed
May 1, 2025
hoodmane
reviewed
May 1, 2025
hoodmane
reviewed
May 1, 2025
hoodmane
reviewed
May 1, 2025
hoodmane
reviewed
May 1, 2025
hoodmane
reviewed
May 1, 2025
e834101 to
bbba8eb
Compare
hoodmane
reviewed
May 7, 2025
hoodmane
reviewed
May 7, 2025
hoodmane
approved these changes
May 7, 2025
Contributor
hoodmane
left a comment
There was a problem hiding this comment.
Looks good to me other than suggestion for using unittest's assertRaises.
97e889f to
172b7a9
Compare
172b7a9 to
f88d72a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relatively large PR which introduces Workers RPC support for Python. The aim is to make it easy to call functions defined in other Python and JS Workers, to do this all arguments are converted to/from JS where appropriate.
The implementation relies on a number of wrappers as well as conversion functions:
envobject is wrapped via thehandlerdecorator, it gets wrapped in a class that intercepts calls toFetcherbindings (i.e.env.ServiceBinding) and then another class that intercepts calls made on that binding. All arguments passed to these calls are wrapped in a call toserialize_to_jsand the returned value from the call is wrapped in a call toserialize_to_python.serialize_to_pythonandserialize_to_jsfunctions convert Python and JS arguments to JS and Python respectively. These mostly use Pyodide'sto_jsandto_pybut with some improvements and restrictions.All of this is supported by a test suite which attempts to send/receive both from and to Python, as well as from and to JS.
Test Plan