EW-9182 Add assertion to detect timeout ID generator mismatches#3867
Merged
harrishancock merged 2 commits intomainfrom Nov 5, 2025
Merged
EW-9182 Add assertion to detect timeout ID generator mismatches#3867harrishancock merged 2 commits intomainfrom
harrishancock merged 2 commits intomainfrom
Conversation
Add instrumentation to verify that the TimeoutId::Generator being used belongs to the ServiceWorkerGlobalScope associated with the current IoContext. This will help diagnose potential timeout ID collisions caused by generators being used with the wrong IoContext. - Add getTimeoutIdGenerator() method to Worker::Lock - Add assertion in TimeoutManagerImpl::setTimeout to validate generator - This will fail early with a descriptive error if the invariant is violated 🤖 Generated with Claude, then lightly edited by Harris Hancock. Co-Authored-By: Claude <noreply@anthropic.com>
anonrig
approved these changes
Apr 8, 2025
Member
|
Couple of tests seem to be failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add instrumentation to verify that the TimeoutId::Generator being used belongs to the ServiceWorkerGlobalScope associated with the current IoContext. This will help diagnose potential timeout ID collisions caused by generators being used with the wrong IoContext.
🤖 Generated with Claude, then lightly edited by Harris Hancock.