Fixes "promise will never complete" when exceeding memory.#3442
Merged
Conversation
jasnell
reviewed
Jan 30, 2025
|
The generated output of |
jasnell
reviewed
Jan 30, 2025
jasnell
reviewed
Jan 30, 2025
198db4d to
eeb33ee
Compare
danlapid
reviewed
Jan 31, 2025
danlapid
approved these changes
Jan 31, 2025
Collaborator
danlapid
left a comment
There was a problem hiding this comment.
LGTM, but I would love to get that comment in 😄
jasnell
approved these changes
Jan 31, 2025
anonrig
approved these changes
Jan 31, 2025
4724fc9 to
66256cd
Compare
66256cd to
25b6b5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we grow WebAssembly memory in a specific way, we can get into a situation where the isolate gets terminated and the termination waiter signal doesn't reach the isolate. This resulted in a promise being rejected with a "Promise will never complete" exception. This PR fixes this so that a more descriptive exception is used.