Conversation
npaun
commented
Jan 29, 2025
npaun
commented
Jan 29, 2025
Member
Author
|
Bad news: I have a Windows build failure too now. |
Collaborator
|
Great work, will review tomorrow. |
anonrig
reviewed
Jan 30, 2025
08ea879 to
307c8a8
Compare
307c8a8 to
265f353
Compare
Try to fix Windows builds; drops files belonging to another target from include
265f353 to
0470f10
Compare
anonrig
approved these changes
Feb 3, 2025
npaun
commented
Feb 3, 2025
Contributor
|
This breaks the downstream build – please fix or revert |
gabivlj
pushed a commit
to gabivlj/workerd
that referenced
this pull request
Jun 18, 2025
Try to fix Windows builds; drops files belonging to another target from include
gabivlj
pushed a commit
to gabivlj/workerd
that referenced
this pull request
Jun 18, 2025
This reverts commit 75d6a76.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables tests from the dom/abortsignal module from WPT.
The following features were added to the harness to support these tests:
Testclass, including step, step_func, step_timeout, step_func_done and doneasync_testtest type