Skip to content

Instantiate Emscripten Runtime for python workers separately#3144

Merged
danlapid merged 1 commit intomainfrom
dlapid/initialize_emscripten
Nov 29, 2024
Merged

Instantiate Emscripten Runtime for python workers separately#3144
danlapid merged 1 commit intomainfrom
dlapid/initialize_emscripten

Conversation

@danlapid
Copy link
Collaborator

@danlapid danlapid commented Nov 20, 2024

Internal PR # 9243.
This is the PR I should've opened a month and a half ago.
This changes basically nothing but separates the emscripten initialization to a separate step which runs in a separate context which we can later move around.

@danlapid danlapid force-pushed the dlapid/initialize_emscripten branch 2 times, most recently from 6d1d32c to 8650f2a Compare November 20, 2024 14:18
@danlapid danlapid marked this pull request as ready for review November 20, 2024 14:41
@danlapid danlapid requested review from a team as code owners November 20, 2024 14:41
@danlapid danlapid force-pushed the dlapid/initialize_emscripten branch from 8650f2a to 269f706 Compare November 20, 2024 14:50
Copy link
Contributor

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @danlapid. I'll publish an update to the bundle.

Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@hoodmane
Copy link
Contributor

Okay you should bump the backport number to 9.

@danlapid danlapid force-pushed the dlapid/initialize_emscripten branch 2 times, most recently from de50812 to 38a085b Compare November 26, 2024 12:49
@danlapid
Copy link
Collaborator Author

Rebased and updated backport in compat-date

@danlapid danlapid force-pushed the dlapid/initialize_emscripten branch 3 times, most recently from 507ab23 to 82dff4c Compare November 28, 2024 20:11
@danlapid danlapid force-pushed the dlapid/initialize_emscripten branch from 82dff4c to 02743b0 Compare November 29, 2024 11:41
@danlapid danlapid merged commit 03b4fa4 into main Nov 29, 2024
@danlapid danlapid deleted the dlapid/initialize_emscripten branch November 29, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants