Skip to content

Python: Fix header conversion to byte-pair on scope building#3142

Merged
hoodmane merged 3 commits intocloudflare:mainfrom
morganabc:patch-1
Dec 3, 2024
Merged

Python: Fix header conversion to byte-pair on scope building#3142
hoodmane merged 3 commits intocloudflare:mainfrom
morganabc:patch-1

Conversation

@morganabc
Copy link

@morganabc morganabc commented Nov 20, 2024

Reopen of #2125

@morganabc morganabc requested review from a team as code owners November 20, 2024 07:40
@morganabc morganabc changed the title Python: Fix header conversion to byte-pair on scope building (from #2125) Python: Fix header conversion to byte-pair on scope building Nov 20, 2024
@dom96 dom96 requested review from dom96 and hoodmane November 20, 2024 13:07
Copy link
Contributor

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience @morgan9e. Looks good to me, just one nit.

@dom96
Copy link
Contributor

dom96 commented Dec 2, 2024

Thanks for this! Looks like the test in the CI is unfortunately failing.

@hoodmane
Copy link
Contributor

hoodmane commented Dec 2, 2024

Test doesn't seem to pass in CI...

@morganabc
Copy link
Author

morganabc commented Dec 2, 2024

It was python_workers_development. I'm not sure what it does but it prevented new asgi.py from loading.

And it now passes the test!

@hoodmane
Copy link
Contributor

hoodmane commented Dec 3, 2024

Thanks for your patience @morgan9e!

@hoodmane hoodmane merged commit e6768de into cloudflare:main Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants