Have Blob use BufferSource for arrayBuffer() also#3097
Merged
Conversation
anonrig
approved these changes
Nov 12, 2024
Member
anonrig
left a comment
There was a problem hiding this comment.
This should apply to all zlib functions as well, I suppose.
Collaborator
Author
There will be quite a few places to make this change. I'll be going through them incrementally with a number of small PRs |
Avoid use of the `kj::Array<kj::byte>` type wrapping entirely for reads (`arrayBuffer()` as well as `bytes()`)
b806110 to
56c6529
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid use of the
kj::Array<kj::byte>type wrapping entirely for reads (arrayBuffer()as well asbytes())