[build] Move io-channels.h back into io target#3092
Merged
Conversation
io-channels.h has a circular dependency with io due to its dependency on io-util.h (parsing the header using bazel is expected to fail accordingly). This means any source file depending on it would need to be in a bazel target depending on io to avoid missing header errors, even if the source file doesn't use io itself. Move it back into io in accordance with IWYU. - Fix dependencies for io:actor-id, util:duration-exceeded-logger - Fix duration-exceeded-logger.h appearing in two targets
365a244 to
e93c311
Compare
Contributor
Author
|
Builds seem to be passing on the eponymous downstream branch. |
dom96
approved these changes
Nov 12, 2024
jasnell
approved these changes
Nov 12, 2024
anonrig
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io-channels.h has a circular dependency with io due to its dependency on io-util.h (parsing the header using bazel is expected to fail accordingly). This means any source file depending on it would need to be in a bazel target depending on io to avoid missing header errors, even if the source file doesn't use io itself. Move it back into io in accordance with IWYU.
- Fix dependencies for io:actor-id, util:duration-exceeded-logger
- Fix duration-exceeded-logger.h appearing in two targets