Skip to content

Bazel 8 support#3013

Merged
fhanau merged 1 commit intomainfrom
felix/bazel-8
May 8, 2025
Merged

Bazel 8 support#3013
fhanau merged 1 commit intomainfrom
felix/bazel-8

Conversation

@fhanau
Copy link
Contributor

@fhanau fhanau commented Oct 27, 2024 •
edited
Loading

  • Remove incompatible flag overrides that are now on-by-default in Bazel
  • Not using bzlmod so far, just adding placeholder MODULE.bazel file
  • Apply workarounds for Windows symlink bugs

@fhanau fhanau force-pushed the felix/bazel-8 branch 6 times, most recently from ea4f630 to 442dd63 Compare November 25, 2024 15:19
@github-actions
Copy link

github-actions bot commented Dec 7, 2024 •
edited
Loading

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@fhanau fhanau force-pushed the felix/bazel-8 branch 2 times, most recently from 892e95b to 54d250f Compare December 9, 2024 23:31
@fhanau fhanau force-pushed the felix/bazel-8 branch 2 times, most recently from fa97abb to 937d431 Compare January 16, 2025 04:52
@fhanau fhanau force-pushed the felix/bazel-8 branch 16 times, most recently from 632d393 to ea0189e Compare January 25, 2025 15:59
@fhanau fhanau force-pushed the felix/bazel-8 branch 2 times, most recently from 121b6bb to 8298caa Compare February 4, 2025 21:19
@fhanau fhanau force-pushed the felix/bazel-8 branch 3 times, most recently from e37fae0 to 072f329 Compare February 14, 2025 01:36
@fhanau fhanau force-pushed the felix/bazel-8 branch 5 times, most recently from eb52691 to 071c54a Compare March 26, 2025 01:52
@fhanau fhanau changed the title [EXP] Bazel 8 support Bazel 8 support Mar 26, 2025
@fhanau fhanau force-pushed the felix/bazel-8 branch 2 times, most recently from cbf9c91 to 695ec01 Compare March 26, 2025 15:00
@fhanau fhanau force-pushed the felix/bazel-8 branch 2 times, most recently from c9a00b9 to 8864811 Compare April 14, 2025 18:13
@fhanau fhanau force-pushed the felix/bazel-8 branch 2 times, most recently from bcce94c to 3d3e29f Compare May 7, 2025 21:10
fhanau
fhanau commented May 7, 2025
View reviewed changes
@fhanau fhanau marked this pull request as ready for review May 7, 2025 21:33
@fhanau fhanau requested review from a team as code owners May 7, 2025 21:33
@fhanau
Bazel 8 support
554b28d 
- Remove incompatible flag overrides that are now on-by-default in Bazel
- Not using bzlmod so far, just adding placeholder MODULE.bazel file
- Apply workarounds for Windows symlink bugs
@fhanau fhanau requested a review from mikea May 7, 2025 23:23
@fhanau fhanau merged commit 5d79fc0 into main May 8, 2025
18 checks passed
@fhanau fhanau deleted the felix/bazel-8 branch May 8, 2025 00:45
danlapid
danlapid reviewed May 8, 2025
View reviewed changes
src/pyodide/helpers.bzl
srcs = native.glob([
"internal/pool/*.ts",
]) + [
], exclude = ["internal/pool/emscriptenSetup.ts"]) + [
Copy link
Collaborator

@danlapid danlapid May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoodmane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danlapid danlapid danlapid left review comments

@anonrig anonrig anonrig approved these changes

@mikea mikea Awaiting requested review from mikea

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fhanau @anonrig @danlapid