Merged
Conversation
penalosa
approved these changes
Aug 20, 2024
jasnell
approved these changes
Aug 20, 2024
danlapid
approved these changes
Aug 20, 2024
anonrig
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is implicated in a regression: #2564.
This PR adds a test case which reliably expresses a null pointer dereference in workerd (although the test itself frustratingly does not fail). The null pointer dereference could plausibly be the root cause of the segfault in #2564. Reverting the CPU profiling fix causes the null pointer dereference to go away.