Add Python development compatibility flag for tests#2560
Conversation
daa0378 to
1664ace
Compare
src/workerd/server/workerd-api.c++
Outdated
| kj::HttpHeaders headers(table); | ||
|
|
||
| kj::String url = kj::str("https://pyodide.runtime-playground.workers.dev/pyodide-capnp-bin/pyodide-", version, ".capnp.bin"); | ||
| kj::String url = kj::str("https://pyodide.runtime-playground.workers.dev/pyodide-capnp-bin/pyodide_", version, ".capnp.bin"); |
There was a problem hiding this comment.
I went ahead and reuploaded pyodide-0.26.0a2_2024-03-01_0.capnp.bin with the underscore, but we should add testing for loading pyodide through the URL since ideally we'd like CI to tell us that the file was missing.
| $pythonSnapshotRelease(pyodide = "0.26.0a2", pyodideRevision = "2024-03-01", | ||
| packages = "2024-03-01", backport = 0); | ||
| packages = "2024-03-01", backport = 0) | ||
| $impliedByAfterDate(name = "pythonWorkersDevPyodide", date = "2000-01-01"); |
There was a problem hiding this comment.
Not sure if I'm understanding this bit. If I set my compatibility date to 2024-02-29, does this mean the python_workers_development flag will be set automatically?
There was a problem hiding this comment.
I believe that it says if pythonWorkersDevPyodide is on and the compat date is after 2000-01-01 (aka always) then pythonWorkers should be on too.
| ], | ||
| compatibilityDate = "2024-05-02", | ||
| compatibilityFlags = ["python_workers"], | ||
| compatibilityFlags = ["python_workers_development"], |
There was a problem hiding this comment.
I wonder if we can do a find-and-replace on this string to generate the two variants of tests we talked about. I'll fiddle around with the bazel and make a PR.
1664ace to
5b2ebce
Compare
905cc6f to
f55c29a
Compare
f55c29a to
c2daf51
Compare
c2daf51 to
791f222
Compare
This also moves toward deriving the bundle name from the compat date.