Conversation
f55b763 to
a671f25
Compare
danlapid
reviewed
Aug 16, 2024
anonrig
reviewed
Aug 16, 2024
Contributor
anonrig
left a comment
There was a problem hiding this comment.
Can you also update compile_flags.txt?
Collaborator
I think that would break "Warnings aren't fatal locally. This is for convenience while working on code." |
fhanau
reviewed
Aug 16, 2024
Contributor
I think these two aspects are key, thank you for covering them. 1) is important for development velocity, 2) means we won't have to fix the many unhelpful Windows warnings we have. Including macOS via |
danlapid
approved these changes
Aug 19, 2024
danlapid
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
-Werror, when building in the CI. As a result, warnings are treated as a fatal error. This ensures that warnings will be addressed, and won't pile up over time in our codebase. Here are some specific details about the configuration.external/. This is because these warnings come from our dependencies, and need to be fixed there.#warningare not fatal. They're just here to give us a heads up that something will need to be fixed eventually.