Conversation
d347b12 to
5c3ff67
Compare
|
I didn't feel like doing it so who am I to throw it on you but if you feel like adding bazel take a look at https://github.com/bazelbuild/buildtools/blob/main/buildifier/README.md |
|
Do we want to use prettier for markdown as well? |
anonrig
left a comment
There was a problem hiding this comment.
I think this is extremely hard to review and land without making sure we don't break anything. What we should do is, to enable prettier new rules on a specific folder, and divide the large chunk to smaller chunks while opening specific pull-requests according to that.
Also, I think we should use a specific prettier config that reduces the changes, and later iterate on finding the "sweet" formatting config that fits to our needs.
npm/lib/node-install.ts
Outdated
| downloadedBinPath, | ||
| pkgAndSubpathForCurrentPlatform, | ||
| } from "./node-platform"; | ||
| } from './node-platform'; |
There was a problem hiding this comment.
These files have already been formatted with prettier, mostly—it seems like this change is just to change the ' to "?
There was a problem hiding this comment.
In this discussion, several colleagues said they preferred single quotes, so I decided to apply it throughout the project.
There was a problem hiding this comment.
Fair enough—as long as we're consistent. Worth noting that we use " in workers-sdk
There was a problem hiding this comment.
Obvs not a big deal but I prefer double quotes since JSON requires them, and being consistent with workers-sdk would be a nice benefit
There was a problem hiding this comment.
I'm on team single quotes, but it's not a big deal for me either.
There was a problem hiding this comment.
We can use different configuration on different folders. We just need to add .prettierrc to the folder where we want to have double quotes.
There was a problem hiding this comment.
I would prefer to have a unified style in all of workerd, but I'm not opposed to per-folder if there is a strong reason
c59be19 to
20a4606
Compare
20a4606 to
2b0b22f
Compare
garrettgu10
left a comment
There was a problem hiding this comment.
I only looked at the pyodide folder but it looked nice, thanks!
2b0b22f to
c08dd6c
Compare
cbb920b to
93d2934
Compare
93d2934 to
a666f32
Compare
a666f32 to
d5b2e51
Compare
This PR extends @danlapid's work in #2505 to format JS/TS/JSON code too.