Removes Python memory snapshot upload code.#2534
Merged
Conversation
garrettgu10
approved these changes
Aug 15, 2024
danlapid
approved these changes
Aug 15, 2024
hoodmane
reviewed
Aug 16, 2024
| ArtifactBundler.isEwValidating() || SHOULD_SNAPSHOT_TO_DISK; | ||
| const SHOULD_UPLOAD_SNAPSHOT = | ||
| ArtifactBundler.isEnabled() || TOP_LEVEL_SNAPSHOT; | ||
| const SHOULD_UPLOAD_SNAPSHOT = TOP_LEVEL_SNAPSHOT; |
Contributor
There was a problem hiding this comment.
Rather than having two redundant names for this, why not combine them? I think SHOULD_UPLOAD_SNAPSHOT is probably the better name.
Contributor
Author
There was a problem hiding this comment.
I wanted to leave that to another PR. Don't want to do too much in one PR.
hoodmane
approved these changes
Aug 16, 2024
Contributor
hoodmane
left a comment
There was a problem hiding this comment.
Always nice to see PRs that remove code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now upload via the validator so this code is no longer needed.