Merged
Conversation
anonrig
reviewed
Aug 12, 2024
| kj::WriteMode::CREATE | kj::WriteMode::MODIFY | kj::WriteMode::CREATE_PARENT); | ||
|
|
||
| // Before we do anything, make sure the database is in WAL mode. | ||
| db->run("PRAGMA journal_mode=WAL;"); |
Contributor
There was a problem hiding this comment.
Is there a test to ensure that the db is in WAL mode?
Member
Author
There was a problem hiding this comment.
I guess not at present.
Technically workerd works fine in any mode, we only enable WAL because it's better.
Storage Relay Service (what we use on the edge) absolutely requires WAL mode, so all its tests would certainly blow up with out it. But it also doesn't depend on workerd setting it; it sets WAL mode itself in internal code.
justin-mp
approved these changes
Aug 12, 2024
Contributor
|
Hmm, the Did we miss a bypass or initialization somewhere? |
e4720b4 to
5294df8
Compare
Member
Author
No, the test was checking for precise error text that depended on the |
In the edge runtime, WAL mode is already set elsewhere, so this statement was redundant there. And anyway, maybe someday we'll have a mode where there's no KV table.
This way, if a Durable Object never actually uses the KV storage interface -- only uses SQL -- we'll never create the table and can skip preparing statements for it. This will also make it easier for the edge runtime to clean up actors that never had data.
5294df8 to
32bdb4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, if a Durable Object never actually uses the KV storage interface -- only uses SQL -- we'll never create the table and can skip preparing statements for it.
This will also make it easier for the edge runtime to clean up actors that never had data.