Conversation
187d13b to
3300551
Compare
fhanau
reviewed
Aug 8, 2024
fhanau
reviewed
Aug 8, 2024
fhanau
reviewed
Aug 8, 2024
fhanau
reviewed
Aug 8, 2024
fhanau
approved these changes
Aug 8, 2024
Contributor
fhanau
left a comment
There was a problem hiding this comment.
Thank you for doing this, I wasn't aware that separating node from io was possible! Left a number of suggestions here but these are largely stylistic concerns and this will be a win either way. Make sure to open a branch on the downstream repo before merging, it is possible that it will require a few changes now that the io target is smaller.
jasnell
approved these changes
Aug 8, 2024
Collaborator
jasnell
left a comment
There was a problem hiding this comment.
LGTM with Felix's suggestions
3300551 to
c4d0843
Compare
c4d0843 to
465a6ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves Node declarations to a separate file to improve caching.