Skip to content

refactor bazel test setup#2495

Merged
garrettgu10 merged 1 commit intoggu/load-pyodide-from-httpfrom
ggu/refactor-bazel-test
Aug 8, 2024
Merged

refactor bazel test setup#2495
garrettgu10 merged 1 commit intoggu/load-pyodide-from-httpfrom
ggu/refactor-bazel-test

Conversation

@garrettgu10
Copy link
Copy Markdown
Contributor

@garrettgu10 garrettgu10 commented Aug 7, 2024

Merge target is load-pyodide-from-http since this change depends on the pyodide bundle disk cache being accepted by workerd.

Changes:

  • introduces new py_wd_test function that automatically includes the pyodide bundle disk cache arguments
  • deletes langchain wd_test

@garrettgu10 garrettgu10 requested review from a team as code owners August 7, 2024 19:15
@garrettgu10 garrettgu10 requested review from hoodmane, mikea and tewaro and removed request for a team, mikea and tewaro August 7, 2024 19:15
@garrettgu10 garrettgu10 force-pushed the ggu/refactor-bazel-test branch from e9d6b11 to d24fab8 Compare August 7, 2024 20:28
@garrettgu10 garrettgu10 requested a review from dom96 August 7, 2024 20:28
Copy link
Copy Markdown
Contributor

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @garrettgu10!

hoodmane

This comment was marked as duplicate.

@garrettgu10 garrettgu10 merged commit 826743f into ggu/load-pyodide-from-http Aug 8, 2024
@garrettgu10 garrettgu10 deleted the ggu/refactor-bazel-test branch August 8, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants