Make wd_tests run in predictable mode by default#6747
Merged
Conversation
0a2bd50 to
01e6232
Compare
Contributor
|
Only one construction site, and it's been updated. After thorough analysis, I don't find any actionable issues. The changes are well-motivated, correctly implemented, and the tests have been appropriately updated. LGTM |
01e6232 to
0675e9e
Compare
jasnell
approved these changes
May 11, 2026
Additionally, make SequentialSpanSubmitter use entropy-based span IDs outside predictable mode. This is especially important for correct trace hierarchy in local dev now that USER_SPAN_CONTEXT_PROPAGATION makes multiple workers emit a combined trace.
0675e9e to
c2afeef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, make SequentialSpanSubmitter use entropy-based span IDs outside predictable mode.
This is especially important for correct trace hierarchy in local dev now that USER_SPAN_CONTEXT_PROPAGATION makes multiple workers emit a combined trace.