Skip to content

Python: Add autogate to call abortIsolate on a fatal error#6708

Merged
hoodmane merged 1 commit into
mainfrom
hoodmane/abortIsolate-on-fatal
May 1, 2026
Merged

Python: Add autogate to call abortIsolate on a fatal error#6708
hoodmane merged 1 commit into
mainfrom
hoodmane/abortIsolate-on-fatal

Conversation

@hoodmane

Copy link
Copy Markdown
Contributor

No description provided.

@hoodmane hoodmane requested review from a team as code owners April 30, 2026 19:26
@ask-bonk

ask-bonk Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

UnknownError: ProviderInitError

github run

@ask-bonk

ask-bonk Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

@hoodmane Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@github-actions

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@hoodmane hoodmane force-pushed the hoodmane/abortIsolate-on-fatal branch 4 times, most recently from 707d311 to e451a41 Compare April 30, 2026 23:42
@codecov-commenter

codecov-commenter commented May 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.53%. Comparing base (a99ab15) to head (2233060).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6708      +/-   ##
==========================================
- Coverage   66.57%   66.53%   -0.04%     
==========================================
  Files         402      402              
  Lines      115911   115864      -47     
  Branches    19407    19407              
==========================================
- Hits        77167    77091      -76     
- Misses      27165    27194      +29     
  Partials    11579    11579              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dom96 dom96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but I don't think this new 'isExperimental' machinery is required (see my comment) and it would be good to see that changed before merge.

Comment thread src/workerd/api/workers-module.h
@hoodmane hoodmane force-pushed the hoodmane/abortIsolate-on-fatal branch from e451a41 to 2233060 Compare May 1, 2026 17:33
@hoodmane hoodmane merged commit d092243 into main May 1, 2026
22 checks passed
@hoodmane hoodmane deleted the hoodmane/abortIsolate-on-fatal branch May 1, 2026 18:30
Comment thread src/workerd/api/workers-module.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants