GC stress mode#6681
Conversation
There was a problem hiding this comment.
I'm an AI code reviewer. Findings may contain errors; please verify before acting on them.
Summary: Adds a GC stress test mode that forces full V8 GC at microtask and awaitIo boundaries, with Bazel test variants and just-recipes.
Findings (1 item):
- [LOW] Freelist bypass in
wrappable.c++is not#ifndef NDEBUG-gated, unlike the GC injection points inio-context.c++.
|
I'm Bonk, and I've done a quick review of your PR. Summary: Adds a GC stress test mode ( One low-severity finding posted as an inline comment:
Overall the implementation is clean and well-documented. The thread-scope flag follows the established |
|
The generated output of |
6e8df83 to
f7fd973
Compare
f7fd973 to
56f0376
Compare
The new mode calls GC just after microtasks and at awaitIO continuations
This catches some cases where an unfortunately timed GC leads
to intermittent issues. Running the just-recipe reveals current
failing tests, but the security issue that it unearthed has been
fixed. Some of the failures are just timing.
Not currently enabled in the CI.