Skip to content

fix: define captureRejections properly#6635

Merged
guybedford merged 2 commits into
mainfrom
capture-rejections-fix
Apr 22, 2026
Merged

fix: define captureRejections properly#6635
guybedford merged 2 commits into
mainfrom
capture-rejections-fix

Conversation

@guybedford

Copy link
Copy Markdown
Contributor

Currently captureRejections is undefined because its defined before its getter on EventEmitter is defined. This hard codes the false value which matches the Node.js behaviour on the ESM wrapper.

Hopefully should reduce some Sentry noise.

@guybedford guybedford requested review from a team as code owners April 22, 2026 02:28
@ask-bonk

ask-bonk Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

UnknownError: ProviderInitError

github run

@ask-bonk

ask-bonk Bot commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

@guybedford Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@codspeed-hq

codspeed-hq Bot commented Apr 22, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks1


Comparing capture-rejections-fix (b7c74c1) with main (206362e)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@guybedford guybedford merged commit 1cbdba6 into main Apr 22, 2026
22 checks passed
@guybedford guybedford deleted the capture-rejections-fix branch April 22, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants