Partial revert of googlesource auth changes#6529
Merged
Merged
Conversation
|
The generated output of |
Contributor
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR reverts the /a/ prefix from googlesource URLs in dependency configs (so external contributors can fetch without auth) and instead adds url.insteadOf git config rewrites in CI to restore authenticated access there.
Issues found:
- [HIGH] Linux CI will break: the
insteadOfURL uses/horse/instead of/a/.
This review was generated by an AI assistant and may contain errors.
Contributor
|
I'm Bonk, and I've done a quick review of your PR. This PR reverts the
|
0bb3beb to
10f215b
Compare
danlapid
approved these changes
Apr 8, 2026
jasnell
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.