containers: In local dev, we should be able to set dns-servers to have predictable /etc/resolv.conf across platforms#6526
Merged
Conversation
…e predictable /etc/resolv.conf across platforms The default in production is 1.1.1.1/8.8.8.8, so match that file. This also fixes an issue where the container tries to reach the Docker DNS resolver which might break egress interception for some users. We should avoid the pattern of local dev of docker reaching its internal DNS gateway, as it can also expose reachability to other containers in the local dev host. Users should leverage intercepting via Workers to reach other containers in the machine to have the same behaviour in both production and local dev.
Contributor
|
Good. The application container uses The PR is straightforward and well-implemented:
The code follows KJ conventions (uses LGTM |
gpanders
approved these changes
Apr 8, 2026
dom96
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default in production is 1.1.1.1/8.8.8.8, so match that file.
This also fixes an issue where the container tries to reach the Docker DNS resolver which might break egress interception for some users.
We should avoid the pattern in local dev of docker reaching its internal DNS gateway, as it can also expose reachability to other containers in the local dev host. Users should leverage intercepting via Workers to reach other containers in the machine to have the same behaviour in both production and local dev.