Conversation
danlapid
approved these changes
Feb 23, 2026
Merging this PR will degrade performance by 16.23%
Performance Changes
Comparing 
Footnotes
|
jasnell
reviewed
Feb 23, 2026
|
|
||
| **JSG bindings:** Changes in jsg/ must correctly bridge V8 and C++. Check type conversions, GC safety, and proper use of jsg:: macros. | ||
|
|
||
| **Node.js compatibility (src/node/, src/workerd/api/node/):** Verify behavior matches Node.js. Check for missing error cases and edge cases in polyfills. |
Collaborator
There was a problem hiding this comment.
We can give this a shot but I'm not sure this is nuanced enough... this may likely end up flagging intentional stubs as issues.
Contributor
Author
There was a problem hiding this comment.
We need an AGENTS.md as well here - if we can get that here we can trim this down too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two ask-bonk GitHub Actions workflows, both restricted to CODEOWNERS only.
bonk.yml-- comment-triggered workflow. Responds to/bonkor@ask-bonkmentions in issue comments, PR comments, and PR reviews. Usescontents: writeso it can push changes when asked. Mirrors the cloudflare-docs bonk.yml.new-pr-review.yml-- auto-reviews new PRs when opened (non-fork only). Usescontents: read(review-only, no auto-fixes). Custom prompt tailored for workerd code review:Skips formatting issues (clang-format handles those). Responds with
LGTMwhen there are no actionable issues.Required secrets (need to be configured if not already present):
CF_AI_GATEWAY_ACCOUNT_IDCF_AI_GATEWAY_NAMECF_AI_GATEWAY_TOKEN