STREAM-6638 Update MediaTransformationResult methods to return Promises#6096
Merged
danlapid merged 2 commits intocloudflare:mainfrom Feb 22, 2026
Merged
Conversation
dario-piotrowicz
approved these changes
Feb 18, 2026
Contributor
Author
|
@danlapid would you mind approving/merging this for me? |
24a5ba0 to
e44e394
Compare
danlapid
approved these changes
Feb 20, 2026
Change media(), response(), and contentType() methods in MediaTransformationResult interface to return Promise types instead of synchronous values. This update aligns the type definitions with the actual existing return types of these methods.
e44e394 to
a14670a
Compare
Merging this PR will improve performance by 30.64%
Performance Changes
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change media(), response(), and contentType() methods in MediaTransformationResult interface to return Promise types instead of synchronous values. This update aligns the type definitions with the actual existing return types of these methods.