Merged
Conversation
86bc0c6 to
65bb6b0
Compare
kentonv
approved these changes
Feb 6, 2026
65bb6b0 to
afa233f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6019
WorkerService::atTime() was scheduling timers using kj::Timer::afterDelay(delay), which internally computes the target time as timer.now() + delay. However, kj::Timer::now() only updates when the event loop polls for I/O — it stays frozen while JavaScript is executing. If significant CPU time elapsed since the last poll (e.g. compiling and running a script before the first setTimeout), timer.now() would be stale by that amount, causing afterDelay() to schedule the timer at a target time that was effectively in the past relative to the real monotonic clock. This made the first setTimeout(fn, 100) resolve in as little as 1ms of wall-clock time, while subsequent calls (which ran after the event loop had polled and refreshed the timer) worked correctly.