Enclose input_gate_lock_hold and input_gate_lock_wait spans into inpu…#5948
Merged
Enclose input_gate_lock_hold and input_gate_lock_wait spans into inpu…#5948
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5948 +/- ##
==========================================
- Coverage 70.18% 70.17% -0.01%
==========================================
Files 407 407
Lines 107237 107238 +1
Branches 17985 17985
==========================================
- Hits 75259 75251 -8
- Misses 21187 21196 +9
Partials 10791 10791 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justin-mp
approved these changes
Jan 26, 2026
d9f80b3 to
2c21a21
Compare
…t_gate_wait_attempt parent span This will help group the lock and wait span from a single request together
2c21a21 to
d41480d
Compare
CodSpeed Performance ReportMerging this PR will improve performance by 22.91%Comparing Summary
Performance Changes
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t_gate_wait_attempt parent span
This will help group the lock and wait span from a single request together
I noticed from this span - https://tracing.cfdata.org/trace/000f2d35a668d2bb that the lock_wait and lock_holds are grouped individually, making it hard to tie the hold and wait to a single request. This change will help fix the issue.