Skip to content

implement jsg::NonCoercible in Rust#5730

Merged
anonrig merged 6 commits intomainfrom
yagiz/rust-jsg-noncoercible
Dec 22, 2025
Merged

implement jsg::NonCoercible in Rust#5730
anonrig merged 6 commits intomainfrom
yagiz/rust-jsg-noncoercible

Conversation

@anonrig
Copy link
Copy Markdown
Member

@anonrig anonrig commented Dec 19, 2025 •
edited
Loading

One step further for future parity

This also introduces a way to test JS code using the TestHarness in Rust.

@anonrig anonrig requested a review from mikea December 19, 2025 20:13
@anonrig anonrig requested review from a team as code owners December 19, 2025 20:13
@anonrig anonrig force-pushed the yagiz/rust-jsg-noncoercible branch 4 times, most recently from ec7a641 to 1ba7446 Compare December 19, 2025 21:13
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 19, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5730 will not alter performance

Comparing yagiz/rust-jsg-noncoercible (1c4c22e) with main (c4f43c1)

Summary

✅ 57 untouched
⏩ 34 skipped1

Footnotes

  1. 34 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@anonrig anonrig force-pushed the yagiz/rust-jsg-noncoercible branch 4 times, most recently from 60b27d2 to 482f512 Compare December 22, 2025 16:51
mikea
mikea reviewed Dec 22, 2025
View reviewed changes
mikea
mikea reviewed Dec 22, 2025
View reviewed changes
mikea
mikea reviewed Dec 22, 2025
View reviewed changes
mikea
mikea reviewed Dec 22, 2025
View reviewed changes
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 22, 2025 •
edited
Loading

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

mikea
mikea reviewed Dec 22, 2025
View reviewed changes
mikea
mikea reviewed Dec 22, 2025
View reviewed changes
mikea
mikea reviewed Dec 22, 2025
View reviewed changes
mikea
mikea reviewed Dec 22, 2025
View reviewed changes
mikea
mikea reviewed Dec 22, 2025
View reviewed changes
@anonrig anonrig force-pushed the yagiz/rust-jsg-noncoercible branch from 32b59e9 to 1e37911 Compare December 22, 2025 17:49
@anonrig anonrig requested a review from mikea December 22, 2025 17:52
mikea
mikea reviewed Dec 22, 2025
View reviewed changes
mikea
mikea reviewed Dec 22, 2025
View reviewed changes
@anonrig anonrig force-pushed the yagiz/rust-jsg-noncoercible branch from 1e37911 to bbc41f4 Compare December 22, 2025 18:02
@anonrig anonrig force-pushed the yagiz/rust-jsg-noncoercible branch from bbc41f4 to 1c4c22e Compare December 22, 2025 18:06
@anonrig
Copy link
Copy Markdown
Member Author

anonrig commented Dec 22, 2025

Rebased and force pushed.

@anonrig anonrig merged commit 91275d4 into main Dec 22, 2025
21 checks passed
@anonrig anonrig deleted the yagiz/rust-jsg-noncoercible branch December 22, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikea mikea mikea approved these changes

@jasnell jasnell Awaiting requested review from jasnell

@guybedford guybedford Awaiting requested review from guybedford

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anonrig @mikea