Ensure that the native dgram node API does not introduce a breaking change#5729
Merged
petebacondarwin merged 3 commits intomainfrom Dec 20, 2025
Merged
Ensure that the native dgram node API does not introduce a breaking change#5729petebacondarwin merged 3 commits intomainfrom
petebacondarwin merged 3 commits intomainfrom
Conversation
13 tasks
CodSpeed Performance ReportMerging #5729 will not alter performanceComparing Summary
Footnotes
|
jasnell
approved these changes
Dec 19, 2025
Collaborator
jasnell
left a comment
There was a problem hiding this comment.
I much prefer failing noisily in general, but ok.
Contributor
Author
Yeah, I hear you. But it would be frustrating if we let this loose and it breaks a bunch of applications for no real reason. Thanks for the review! |
anonrig
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation throws "not implemented" errors when constructing a Socket and when calling the Socket's methods, which is different to Node.js and the unenv polyfill. Now they are simple noops, inline with unenv.
This change will allow us to safely remove the node:dgram polyfill from the Cloudflare unenv preset.
For reference:
Node.js implementation
unenv implementation